Skip to content

Conversation

@jubittajohn
Copy link
Contributor

also adds appropriate directory structure since these are the first runbooks for the cluster-openshift-apiserver operator.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 29, 2025
@openshift-ci-robot
Copy link

@jubittajohn: This pull request references Jira Issue OCPBUGS-56821, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

also adds appropriate directory structure since these are the first runbooks for the cluster-openshift-apiserver operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier
Copy link
Contributor

❤️ if you want to, you can submit a first PR to add the directory + OWNERS file then you wouldn't need approval from the top-level OWNERS.

@flavianmissi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@simonpasquier
Copy link
Contributor

Since @flavianmissi is happy with it, I'm approving it. Feel free to undraft when you're ready.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@jubittajohn jubittajohn marked this pull request as ready for review October 31, 2025 14:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 99e1365 and 2 for PR HEAD 0dccc26 in total

@jubittajohn jubittajohn force-pushed the image-stream-import-error-alert branch from 0dccc26 to 5ac3943 Compare October 31, 2025 15:19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@jubittajohn
Copy link
Contributor Author

jubittajohn commented Oct 31, 2025

@simonpasquier Had to fix the linting errors (making sure no more than 80 characters in a line and removing extra trailing spaces). Could you re-review and approve the changes.

@simonpasquier
Copy link
Contributor

Approval is preserved. You can have someone else (@flavianmissi?) lgtm the PR :)

@ricardomaraschini
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, jubittajohn, ricardomaraschini, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fb7727b and 2 for PR HEAD 5ac3943 in total

@simonpasquier
Copy link
Contributor

note that the configuration of markdownlint job needs a fix (openshift/release#71749).

@jubittajohn
Copy link
Contributor Author

/test markdownlint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

@jubittajohn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 63e33cf into openshift:master Nov 24, 2025
2 checks passed
@openshift-ci-robot
Copy link

@jubittajohn: Jira Issue OCPBUGS-56821: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-56821 has not been moved to the MODIFIED state.

In response to this:

also adds appropriate directory structure since these are the first runbooks for the cluster-openshift-apiserver operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants